Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses two types of Python warnings in the codebase: DeprecationWarning for invalid escape sequences in regex patterns and PytestReturnNotNoneWarning for test functions returning values. The fixes are straightforward and maintain the same functionality while eliminating the warnings.
Changes:
- Converted regex pattern strings to raw strings (r-prefix) to properly handle escape sequences
- Removed return statements from test functions to comply with pytest conventions
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/test_ast.py | Removed return statements from test functions that were causing PytestReturnNotNoneWarning |
| core/rule_parser.py | Converted regex patterns to raw strings to fix DeprecationWarning for invalid escape sequences |
| core/rule_generator.py | Converted regex patterns to raw strings to fix DeprecationWarning for invalid escape sequences |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
baiqiushi
approved these changes
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview:
This PR fixes a warning in regex expressions by using raw strings for regex expressions. The PR also fixes a warning for unused return statements in ast test cases.
Example warnings:
Code Changes:
rule_parser.pyandrule_generator.pytest_ast.py